[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 06/31] target/ppc: Simplify gen_debug_exception
From: |
David Gibson |
Subject: |
Re: [PATCH v4 06/31] target/ppc: Simplify gen_debug_exception |
Date: |
Thu, 13 May 2021 14:08:23 +1000 |
On Wed, May 12, 2021 at 03:54:16PM -0300, matheus.ferst@eldorado.org.br wrote:
> From: Richard Henderson <richard.henderson@linaro.org>
>
> Two of the call sites that use gen_debug_exception have already
> updated NIP. Only ppc_tr_breakpoint_check requires the update.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
Applied to ppc-for-6.1, thanks.
> ---
> target/ppc/translate.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 23de04a08e..7b23f85c11 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -326,19 +326,7 @@ static uint32_t gen_prep_dbgex(DisasContext *ctx)
>
> static void gen_debug_exception(DisasContext *ctx)
> {
> - TCGv_i32 t0;
> -
> - /*
> - * These are all synchronous exceptions, we set the PC back to the
> - * faulting instruction
> - */
> - if ((ctx->exception != POWERPC_EXCP_BRANCH) &&
> - (ctx->exception != POWERPC_EXCP_SYNC)) {
> - gen_update_nip(ctx, ctx->base.pc_next);
> - }
> - t0 = tcg_const_i32(EXCP_DEBUG);
> - gen_helper_raise_exception(cpu_env, t0);
> - tcg_temp_free_i32(t0);
> + gen_helper_raise_exception(cpu_env, tcg_constant_i32(EXCP_DEBUG));
> ctx->base.is_jmp = DISAS_NORETURN;
> }
>
> @@ -9377,6 +9365,7 @@ static bool ppc_tr_breakpoint_check(DisasContextBase
> *dcbase, CPUState *cs,
> {
> DisasContext *ctx = container_of(dcbase, DisasContext, base);
>
> + gen_update_nip(ctx, ctx->base.pc_next);
> gen_debug_exception(ctx);
> /*
> * The address covered by the breakpoint must be included in
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [PATCH v4 02/31] target/ppc: Split out decode_legacy, (continued)
- [PATCH v4 01/31] target/ppc: Add cia field to DisasContext, matheus . ferst, 2021/05/12
- [PATCH v4 03/31] target/ppc: Move DISAS_NORETURN setting into gen_exception*, matheus . ferst, 2021/05/12
- [PATCH v4 05/31] target/ppc: Remove special case for POWERPC_EXCP_TRAP, matheus . ferst, 2021/05/12
- [PATCH v4 04/31] target/ppc: Remove special case for POWERPC_SYSCALL, matheus . ferst, 2021/05/12
- [PATCH v4 06/31] target/ppc: Simplify gen_debug_exception, matheus . ferst, 2021/05/12
- Re: [PATCH v4 06/31] target/ppc: Simplify gen_debug_exception,
David Gibson <=
- [PATCH v4 07/31] target/ppc: Introduce DISAS_{EXIT,CHAIN}{,_UPDATE}, matheus . ferst, 2021/05/12
- [PATCH v4 08/31] target/ppc: Replace POWERPC_EXCP_SYNC with DISAS_EXIT, matheus . ferst, 2021/05/12
- [PATCH v4 09/31] target/ppc: Remove unnecessary gen_io_end calls, matheus . ferst, 2021/05/12
- [PATCH v4 10/31] target/ppc: Introduce gen_icount_io_start, matheus . ferst, 2021/05/12