Re: [PATCH 03/11] target/ppc: moved ppc_cpu_dump_state to cpu_init.c

[Richard Henderson]

On 5/12/21 11:58 AM, Richard Henderson wrote:
> On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote:
> > This function was forgotten in the cpu_init code motion series, but it
> > seems to be used regardless of TCG, and so needs to be moved to support
> > disabling TCG.
> >
> > Signed-off-by: Bruno Larsen (billionai)<bruno.larsen@eldorado.org.br>
> > ---
> >   target/ppc/cpu_init.c  | 182 +++++++++++++++++++++++++++++++++++++++
> >   target/ppc/translate.c | 187 -----------------------------------------
> >   2 files changed, 182 insertions(+), 187 deletions(-)
>
> Not just "seems to be" -- "is".
>
> Indeed, cpu_dump_state is called from accel/kvm/kvm-all.c, and the monitor.

... and I meant to include

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~