Re: [PULL 30/33] migration: do not restart VM after successful snapshot-load

[Kevin Wolf]

Am 11.05.2021 um 19:06 hat Daniel P. Berrangé geschrieben:
> On Tue, May 11, 2021 at 04:13:47AM -0400, Paolo Bonzini wrote:
> > The HMP loadvm code is calling load_snapshot rather than
> > qmp_snapshot_load, in order to bypass the job infrastructure.  The code
> > around it is almost the same, with one difference: hmp_loadvm is
> > restarting the VM if load_snapshot fails, qmp_snapshot_load is doing so
> > if load_snapshot succeeds.
> > 
> > Fix the bug in QMP by moving the common code to load_snapshot.
> 
> This doesn't appear to have actually fixed the HMP regression.
> Instead I think it is duplicated the HMP bug in the QMP code
> too.
> 
> See the 068  iotest enhancement here that validates the expected
> state on success:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg03091.html

I guess I'll wait for this new QMP bug to hit master, and then rebase my
fix on top of it, with now two Fixes: lines.

Or do you want to send a v2 of this pull request without this patch,
Paolo?

Kevin