[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/17] migration/ram: Reduce unnecessary rate limiting
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 02/17] migration/ram: Reduce unnecessary rate limiting |
Date: |
Tue, 11 May 2021 16:08:27 +0100 |
From: Kunkun Jiang <jiangkunkun@huawei.com>
When the host page is a huge page and something is sent in the
current iteration, migration_rate_limit() should be executed.
If not, it can be omitted.
Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20210316125716.1243-2-jiangkunkun@huawei.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/ram.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index bee2756cd3..00b579b981 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2035,8 +2035,13 @@ static int ram_save_host_page(RAMState *rs,
PageSearchStatus *pss,
pages += tmppages;
pss->page++;
- /* Allow rate limiting to happen in the middle of huge pages */
- migration_rate_limit();
+ /*
+ * Allow rate limiting to happen in the middle of huge pages if
+ * something is sent in the current iteration.
+ */
+ if (pagesize_bits > 1 && tmppages > 0) {
+ migration_rate_limit();
+ }
} while ((pss->page & (pagesize_bits - 1)) &&
offset_in_ramblock(pss->block,
((ram_addr_t)pss->page) << TARGET_PAGE_BITS));
--
2.31.1
- [PULL 00/17] migration queue, Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 01/17] migrate/ram: remove "ram_bulk_stage" and "fpo_enabled", Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 03/17] migration/ram: Optimize ram_save_host_page(), Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 02/17] migration/ram: Reduce unnecessary rate limiting,
Dr. David Alan Gilbert (git) <=
- [PULL 04/17] migration: Drop redundant query-migrate result @blocked, Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 05/17] util: vfio-helpers: Factor out and fix processing of existing ram blocks, Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 06/17] numa: Teach ram block notifiers about resizeable ram blocks, Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 07/17] numa: Make all callbacks of ram block notifiers optional, Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 08/17] migration/ram: Handle RAM block resizes during precopy, Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 10/17] migration/ram: Discard RAM when growing RAM blocks after ram_postcopy_incoming_init(), Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 11/17] migration/ram: Simplify host page handling in ram_load_postcopy(), Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 12/17] migration/ram: Handle RAM block resizes during postcopy, Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 13/17] migration/multifd: Print used_length of memory block, Dr. David Alan Gilbert (git), 2021/05/11
- [PULL 14/17] migration/ram: Use offset_in_ramblock() in range checks, Dr. David Alan Gilbert (git), 2021/05/11