Re: [PATCH 5/6] co-shared-resource: protect with a mutex

[Paolo Bonzini]

On 10/05/21 13:40, Vladimir Sementsov-Ogievskiy wrote:
> > co-shared-resource is currently not thread-safe, as also reported
> > in co-shared-resource.h. Add a QemuMutex because co_try_get_from_shres
> > can also be invoked from non-coroutine context.
>
> But it doesn't. It's called only from co_get_from_shres(). So, better 
> make it a static function first.

It's a sensible interface though.  It lets you sleep or retry in your 
own way if you cannot get the resources, so (apart from the 
unlocked/locked confusion in the names) I like keeping it in the public API.

Paolo