Re: [PATCH] hw/pci-host: Do not build gpex-acpi.c if GPEX is not selected

[Philippe Mathieu-Daudé]

Cc'ing qemu-trivial (patch reviewed).

On 4/25/21 8:21 PM, Philippe Mathieu-Daudé wrote:
> Since its introduction in commit 5b85eabe68f ("acpi: add
> acpi_dsdt_add_gpex") we build gpex-acpi.c if ACPI is selected,
> even if the GPEX_HOST device isn't build. Add the missing
> Kconfig dependency.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> The gpex*.c files aren't covered by any MAINTAINERS section:
> 
> $ ./scripts/get_maintainer.pl -f hw/pci-host/gpex.c -f hw/pci-host/gpex-acpi.c
> get_maintainer.pl: No maintainers found, printing recent contributors.
> get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.
> 
> Markus Armbruster <armbru@redhat.com> (commit_signer:2/2=100%)
> Paolo Bonzini <pbonzini@redhat.com> (commit_signer:2/2=100%)
> Alistair Francis <alistair.francis@wdc.com> (commit_signer:1/2=50%)
> "Philippe Mathieu-Daudé" <philmd@redhat.com> (commit_signer:1/2=50%)
> "Michael S. Tsirkin" <mst@redhat.com> (commit_signer:14/8=100%)
> Jiahui Cen <cenjiahui@huawei.com> (commit_signer:6/8=75%)
> Igor Mammedov <imammedo@redhat.com> (commit_signer:4/8=50%)
> Gerd Hoffmann <kraxel@redhat.com> (commit_signer:2/8=25%)
> Yubo Miao <miaoyubo@huawei.com> (commit_signer:2/8=25%)
> qemu-devel@nongnu.org (open list:All patches CC here)
> ---
>  hw/pci-host/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/pci-host/meson.build b/hw/pci-host/meson.build
> index 87a896973e7..d52dce77cbd 100644
> --- a/hw/pci-host/meson.build
> +++ b/hw/pci-host/meson.build
> @@ -3,7 +3,7 @@
>  pci_ss.add(when: 'CONFIG_PCI_BONITO', if_true: files('bonito.c'))
>  pci_ss.add(when: 'CONFIG_PCI_EXPRESS_DESIGNWARE', if_true: 
> files('designware.c'))
>  pci_ss.add(when: 'CONFIG_PCI_EXPRESS_GENERIC_BRIDGE', if_true: 
> files('gpex.c'))
> -pci_ss.add(when: 'CONFIG_ACPI', if_true: files('gpex-acpi.c'))
> +pci_ss.add(when: ['CONFIG_PCI_EXPRESS_GENERIC_BRIDGE', 'CONFIG_ACPI'], 
> if_true: files('gpex-acpi.c'))
>  pci_ss.add(when: 'CONFIG_PCI_EXPRESS_Q35', if_true: files('q35.c'))
>  pci_ss.add(when: 'CONFIG_PCI_EXPRESS_XILINX', if_true: 
> files('xilinx-pcie.c'))
>  pci_ss.add(when: 'CONFIG_PCI_I440FX', if_true: files('i440fx.c'))
>