[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 7/9] gdbstub: Replace alloca() + memset(0) by g_new0()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 7/9] gdbstub: Replace alloca() + memset(0) by g_new0() |
Date: |
Thu, 6 May 2021 15:37:56 +0200 |
The ALLOCA(3) man-page mentions its "use is discouraged".
Replace the alloca() and memset(0) calls by g_new0().
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
gdbstub.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 7cee2fb0f1f..666053bf590 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1487,14 +1487,13 @@ static int process_string_cmd(void *user_ctx, const
char *data,
if (cmd->schema) {
int schema_len = strlen(cmd->schema);
int max_num_params = schema_len / 2;
+ g_autofree GdbCmdVariant *params = NULL;
if (schema_len % 2) {
return -2;
}
- gdb_ctx.params = (GdbCmdVariant *)alloca(sizeof(*gdb_ctx.params)
- * max_num_params);
- memset(gdb_ctx.params, 0, sizeof(*gdb_ctx.params) *
max_num_params);
+ gdb_ctx.params = params = g_new0(GdbCmdVariant, max_num_params);
if (cmd_parse_params(&data[strlen(cmd->cmd)], cmd->schema,
gdb_ctx.params, &gdb_ctx.num_params)) {
--
2.26.3
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), (continued)
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Eric Blake, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Warner Losh, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Eric Blake, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Peter Maydell, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Warner Losh, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Peter Maydell, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Warner Losh, 2021/05/06
[PATCH v2 5/9] gdbstub: Constify GdbCmdParseEntry, Philippe Mathieu-Daudé, 2021/05/06
[PATCH v2 6/9] gdbstub: Only call cmd_parse_params() with non-NULL command schema, Philippe Mathieu-Daudé, 2021/05/06
[PATCH v2 7/9] gdbstub: Replace alloca() + memset(0) by g_new0(),
Philippe Mathieu-Daudé <=
[PATCH v2 8/9] hw/misc/pca9552: Replace g_newa() by g_new(), Philippe Mathieu-Daudé, 2021/05/06
[PATCH v2 9/9] target/ppc/kvm: Replace alloca() by g_malloc(), Philippe Mathieu-Daudé, 2021/05/06
Re: [PATCH v2 0/9] misc: Replace alloca() by g_malloc(), Warner Losh, 2021/05/06