[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/9] backends/tpm: Replace g_alloca() by g_malloc()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 3/9] backends/tpm: Replace g_alloca() by g_malloc() |
Date: |
Thu, 6 May 2021 15:37:52 +0200 |
The ALLOCA(3) man-page mentions its "use is discouraged".
Replace a g_alloca() call by a g_malloc() one, moving the
allocation before the MUTEX guarded block.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
backends/tpm/tpm_emulator.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c
index e5f1063ab6c..d37a6d563a3 100644
--- a/backends/tpm/tpm_emulator.c
+++ b/backends/tpm/tpm_emulator.c
@@ -124,10 +124,9 @@ static int tpm_emulator_ctrlcmd(TPMEmulator *tpm, unsigned
long cmd, void *msg,
CharBackend *dev = &tpm->ctrl_chr;
uint32_t cmd_no = cpu_to_be32(cmd);
ssize_t n = sizeof(uint32_t) + msg_len_in;
- uint8_t *buf = NULL;
+ g_autofree uint8_t *buf = g_malloc(n);
WITH_QEMU_LOCK_GUARD(&tpm->mutex) {
- buf = g_alloca(n);
memcpy(buf, &cmd_no, sizeof(cmd_no));
memcpy(buf + sizeof(cmd_no), msg, msg_len_in);
--
2.26.3