[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/22] qapi/parser: add type hint annotations
From: |
John Snow |
Subject: |
Re: [PATCH 12/22] qapi/parser: add type hint annotations |
Date: |
Wed, 5 May 2021 21:27:05 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/21/21 11:07 PM, John Snow wrote:
+ self.exprs: List[Expression] = []
I did indeed intend to use Expression to mean TopLevelExpr ... However,
in this case, that's not what actually gets stored here.
I tricked myself!
This stores the dict that associates 'expr', 'doc' and 'info'.
Fixing it to be the generic Dict[str, object] removes the last usage of
TopLevelExpr from parser.py ... for now.
(pt5c, optional parser cleanups, uses a stronger type for parser's
return type and sees the reintroduction of that type.)
--js
- Re: [PATCH 12/22] qapi/parser: add type hint annotations,
John Snow <=