|
From: | Paolo Bonzini |
Subject: | Re: [PATCH v1] softmmu/vl: make default prealloc-threads work w/o -mem-prealloc |
Date: | Wed, 5 May 2021 17:31:28 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 11/03/21 09:59, Denis Plotnikov wrote:
diff --git a/softmmu/vl.c b/softmmu/vl.c index ff488ea3e7db..e392e226a2d3 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -2300,14 +2300,17 @@ static void qemu_validate_options(void)static void qemu_process_sugar_options(void){ - if (mem_prealloc) { - char *val; + char *val;- val = g_strdup_printf("%d",- (uint32_t) qemu_opt_get_number(qemu_find_opts_singleton("smp-opts"), "cpus", 1)); - object_register_sugar_prop("memory-backend", "prealloc-threads", val, - false); - g_free(val); + val = g_strdup_printf("%d", + (uint32_t) qemu_opt_get_number( + qemu_find_opts_singleton("smp-opts"), "cpus", 1)); + + object_register_sugar_prop("memory-backend", "prealloc-threads", val, + false); + g_free(val); + + if (mem_prealloc) { object_register_sugar_prop("memory-backend", "prealloc", "on", false); }
Hi Denis, this patch breaks make check-qtest-arm: G_TEST_DBUS_DAEMON=/home/pbonzini/work/upstream/qemu/tests/dbus-vmstate-daemon.sh QTEST_QEMU_IMG=./qemu-img MALLOC_PERTURB_=45 QTEST_QEMU_BINARY=./qemu-system-arm /home/pbonzini/work/upstream/qemu/+bb/tests/qtest/npcm7xx_emc-test --tap -k # random seed: R02Sac2b21edc4fb48abab9f9723147ddbd5 1..6 # Start of arm tests # Start of npcm7xx_emc tests # Start of emc[0] tests # starting QEMU: exec ./qemu-system-arm -qtest unix:/tmp/qtest-839596.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-839596.qmp,id=char0 -mon chardev=char0,mode=control -display none -machine quanta-gsj -accel qtest qemu-system-arm: Invalid SMP CPUs 1. The min CPUs supported by machine 'quanta-gsj' is 2 Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |