[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/migration-test: Fix "true" vs true
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] tests/migration-test: Fix "true" vs true |
Date: |
Tue, 4 May 2021 12:08:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/4/21 12:05 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Accidental use of "true" as a boolean; spotted by coverity
> and Peter.
>
> Fixes: b99784ef6c3
> Fixes: d795f47466e
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Reported-by: Coverity (CID 1432373, 1432292, 1432288)
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> tests/qtest/migration-test.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 3a711bb492..4d989f191b 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -898,8 +898,8 @@ static void test_xbzrle(const char *uri)
>
> migrate_set_parameter_int(from, "xbzrle-cache-size", 33554432);
>
> - migrate_set_capability(from, "xbzrle", "true");
> - migrate_set_capability(to, "xbzrle", "true");
> + migrate_set_capability(from, "xbzrle", true);
> + migrate_set_capability(to, "xbzrle", true);
Funny one =)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>