[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/7] usb/redir: avoid dynamic stack allocation (CVE-2021-3527)
From: |
Gerd Hoffmann |
Subject: |
[PULL 4/7] usb/redir: avoid dynamic stack allocation (CVE-2021-3527) |
Date: |
Tue, 4 May 2021 10:53:14 +0200 |
Use autofree heap allocation instead.
Fixes: 4f4321c11ff ("usb: use iovecs in USBPacket")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210503132915.2335822-3-kraxel@redhat.com>
---
hw/usb/redirect.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 17f06f34179a..6a75b0dc4ab2 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -620,7 +620,7 @@ static void usbredir_handle_iso_data(USBRedirDevice *dev,
USBPacket *p,
.endpoint = ep,
.length = p->iov.size
};
- uint8_t buf[p->iov.size];
+ g_autofree uint8_t *buf = g_malloc(p->iov.size);
/* No id, we look at the ep when receiving a status back */
usb_packet_copy(p, buf, p->iov.size);
usbredirparser_send_iso_packet(dev->parser, 0, &iso_packet,
@@ -818,7 +818,7 @@ static void usbredir_handle_bulk_data(USBRedirDevice *dev,
USBPacket *p,
usbredirparser_send_bulk_packet(dev->parser, p->id,
&bulk_packet, NULL, 0);
} else {
- uint8_t buf[size];
+ g_autofree uint8_t *buf = g_malloc(size);
usb_packet_copy(p, buf, size);
usbredir_log_data(dev, "bulk data out:", buf, size);
usbredirparser_send_bulk_packet(dev->parser, p->id,
@@ -923,7 +923,7 @@ static void
usbredir_handle_interrupt_out_data(USBRedirDevice *dev,
USBPacket *p, uint8_t ep)
{
struct usb_redir_interrupt_packet_header interrupt_packet;
- uint8_t buf[p->iov.size];
+ g_autofree uint8_t *buf = g_malloc(p->iov.size);
DPRINTF("interrupt-out ep %02X len %zd id %"PRIu64"\n", ep,
p->iov.size, p->id);
--
2.31.1
- [PULL 0/7] Usb 20210504 patches, Gerd Hoffmann, 2021/05/04
- [PULL 1/7] hw/usb/host-stub: Remove unused header, Gerd Hoffmann, 2021/05/04
- [PULL 3/7] usb/hid: avoid dynamic stack allocation, Gerd Hoffmann, 2021/05/04
- [PULL 2/7] hw/usb: Do not build USB subsystem if not required, Gerd Hoffmann, 2021/05/04
- [PULL 5/7] usb/mtp: avoid dynamic stack allocation, Gerd Hoffmann, 2021/05/04
- [PULL 4/7] usb/redir: avoid dynamic stack allocation (CVE-2021-3527),
Gerd Hoffmann <=
- [PULL 6/7] usb/xhci: sanity check packet size (CVE-2021-3527), Gerd Hoffmann, 2021/05/04
- [PULL 7/7] usb: limit combined packets to 1 MiB (CVE-2021-3527), Gerd Hoffmann, 2021/05/04
- Re: [PULL 0/7] Usb 20210504 patches, Gerd Hoffmann, 2021/05/05