[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKe
From: |
Wainer dos Santos Moschetta |
Subject: |
[PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest |
Date: |
Mon, 3 May 2021 19:43:23 -0300 |
The Sun4uMachine class inherit from LinuxKernelTest to effectively only use
the KERNEL_COMMON_COMMAND_LINE attribute. This change remove that unneeded
dependency, making Sun4uMachine self-content.
I took the occasion to delint the code: the unused os import was
removed, imports were reordered, and the module has a docstring now.
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
tests/acceptance/machine_sparc64_sun4u.py | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tests/acceptance/machine_sparc64_sun4u.py
b/tests/acceptance/machine_sparc64_sun4u.py
index 458165500e..c7ad474bdc 100644
--- a/tests/acceptance/machine_sparc64_sun4u.py
+++ b/tests/acceptance/machine_sparc64_sun4u.py
@@ -1,4 +1,4 @@
-# Functional test that boots a Linux kernel and checks the console
+"""Functional test that boots a Linux kernel and checks the console"""
#
# Copyright (c) 2020 Red Hat, Inc.
#
@@ -8,16 +8,15 @@
# This work is licensed under the terms of the GNU GPL, version 2 or
# later. See the COPYING file in the top-level directory.
-import os
-
-from avocado_qemu import wait_for_console_pattern
from avocado.utils import archive
-from boot_linux_console import LinuxKernelTest
+from avocado_qemu import Test
+from avocado_qemu import wait_for_console_pattern
-class Sun4uMachine(LinuxKernelTest):
+class Sun4uMachine(Test):
"""Boots the Linux kernel and checks that the console is operational"""
timeout = 90
+ KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
def test_sparc64_sun4u(self):
"""
--
2.29.2
- [PATCH 0/7] tests/acceptance: Introducing the ConsoleMixIn, Wainer dos Santos Moschetta, 2021/05/03
- [PATCH 1/7] tests/acceptance: Introduce the ConsoleMixIn class, Wainer dos Santos Moschetta, 2021/05/03
- [PATCH 2/7] tests/acceptance: Move exec_command to ConsoleMixIn, Wainer dos Santos Moschetta, 2021/05/03
- [PATCH 3/7] tests/acceptance: Move exec_command_and_wait_for_pattern to ConsoleMixIn, Wainer dos Santos Moschetta, 2021/05/03
- [PATCH 5/7] tests/acceptance: replay_kernel: Remove unused wait_for_console_pattern, Wainer dos Santos Moschetta, 2021/05/03
- [PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest,
Wainer dos Santos Moschetta <=
- Re: [PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest, Willian Rampazzo, 2021/05/24
- [PATCH 7/7] tests/acceptance: Move _console_interaction to ConsoleMixIn, Wainer dos Santos Moschetta, 2021/05/03
- [PATCH 6/7] tests/acceptance: Move wait_for_console_pattern to ConsoleMixIn, Wainer dos Santos Moschetta, 2021/05/03
- Re: [PATCH 0/7] tests/acceptance: Introducing the ConsoleMixIn, Willian Rampazzo, 2021/05/24