[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] qemu-img: Require -F with -b backing image
From: |
Eric Blake |
Subject: |
Re: [PATCH 2/2] qemu-img: Require -F with -b backing image |
Date: |
Mon, 3 May 2021 16:45:51 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/3/21 4:36 PM, Eric Blake wrote:
> Back in commit d9f059aa6c (qemu-img: Deprecate use of -b without -F),
> we deprecated the ability to create a file with a backing image that
> requires qemu to perform format probing. Qemu can still probe older
> files for backwards compatibility, but it is time to finish off the
> ability to create such images, due to the potential security risk they
> present. Update a couple of iotests affected by the change.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> docs/system/deprecated.rst | 20 -----------------
> docs/system/removed-features.rst | 19 ++++++++++++++++
> block.c | 37 ++++++++++----------------------
> qemu-img.c | 6 ++++--
> tests/qemu-iotests/114 | 18 ++++++++--------
> tests/qemu-iotests/114.out | 11 ++++------
> tests/qemu-iotests/301 | 4 +---
> tests/qemu-iotests/301.out | 16 ++------------
> 8 files changed, 50 insertions(+), 81 deletions(-)
I'll need a followup to fix iotest failures in 40 and 41 (apparently
they weren't passing backing formats, but I did not catch them in my
original cleanup of iotests back in commit b66ff2c298)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org