|
From: | Richard Henderson |
Subject: | Re: [PATCH v3 4/7] target/ppc: turned SPR R/W callbacks not static |
Date: | Mon, 3 May 2021 08:25:57 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 5/3/21 4:28 AM, Bruno Piazera Larsen wrote:
Note for future cleanup: Make spr_tcg.c be standalone as well. Just need to move a few declarations to a translate.h.it's not that easy, unfortunately. The readers and writers use a lot of global variables declared in translate.c, so we'd need to create getters and setters, or some better solution, before doing that.
No need for getters, and certainly not for setters (all of the globals are write-once at startup). Just move the declarations into a shared translate.h. That's what we've done for target/arm/.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |