[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/5] usb/hid: avoid dynamic stack allocation
From: |
Gerd Hoffmann |
Subject: |
[PATCH 1/5] usb/hid: avoid dynamic stack allocation |
Date: |
Mon, 3 May 2021 11:14:42 +0200 |
Use autofree heap allocation instead.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/dev-hid.c | 2 +-
hw/usb/dev-wacom.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
index fc39bab79f94..1c7ae97c3033 100644
--- a/hw/usb/dev-hid.c
+++ b/hw/usb/dev-hid.c
@@ -656,7 +656,7 @@ static void usb_hid_handle_data(USBDevice *dev, USBPacket
*p)
{
USBHIDState *us = USB_HID(dev);
HIDState *hs = &us->hid;
- uint8_t buf[p->iov.size];
+ g_autofree uint8_t *buf = g_malloc(p->iov.size);
int len = 0;
switch (p->pid) {
diff --git a/hw/usb/dev-wacom.c b/hw/usb/dev-wacom.c
index b59504863509..ed687bc9f1eb 100644
--- a/hw/usb/dev-wacom.c
+++ b/hw/usb/dev-wacom.c
@@ -301,7 +301,7 @@ static void usb_wacom_handle_control(USBDevice *dev,
USBPacket *p,
static void usb_wacom_handle_data(USBDevice *dev, USBPacket *p)
{
USBWacomState *s = (USBWacomState *) dev;
- uint8_t buf[p->iov.size];
+ g_autofree uint8_t *buf = g_malloc(p->iov.size);
int len = 0;
switch (p->pid) {
--
2.30.2
- [PATCH 0/5] usb: fix some memory allocation issues., Gerd Hoffmann, 2021/05/03
- [PATCH 3/5] usb/mtp: avoid dynamic stack allocation, Gerd Hoffmann, 2021/05/03
- [PATCH 1/5] usb/hid: avoid dynamic stack allocation,
Gerd Hoffmann <=
- [PATCH 2/5] usb/redir: avoid dynamic stack allocation (CVE-2021-3527), Gerd Hoffmann, 2021/05/03
- [PATCH 5/5] usb: limit combined packets to 1 MiB, Gerd Hoffmann, 2021/05/03
- [PATCH 4/5] usb/xhci: sanity check packet size, Gerd Hoffmann, 2021/05/03
- Re: [PATCH 0/5] usb: fix some memory allocation issues., Philippe Mathieu-Daudé, 2021/05/03