Re: [PATCH v2 7/7] target/ppc: isolated cpu init from translation logic

[Richard Henderson]

On 4/30/21 10:12 AM, Bruno Piazera Larsen wrote:
> > > +#include "helper_regs.h"
> > > +#include "internal.h"
> > > +#include "spr_tcg.h"
> > These two includes look like they belong in patch 3 and 4 respectively.
> >
> > And we probably want an #ifdef CONFIG_TCG around them.
>
> Just to make sure, you mean spr_tcg.h and internal.h, right?
>
> Internal.h needs to be included regardless, since it holds some functions 
> always required for init_proc, like ppc_gdb_init. These bits will be removed on 
> the patch series that specifically disable them if we can.
>
> spr_tcg.h only has function prototypes, so I don't think it's a problem to 
> include it in case of !TCG. Some .h were removed in the other RFC because they 
> needed files that weren't in the include path. If we should remove it anyway, I 
> can add that :)

I wouldn't add an ifdef for CONFIG_TCG.  That would just force you to add more 
conditional compilation elsewhere.  So long as the symbols are either unused or 
optimized away, we'll be fine.


r~