RE: [PATCH v2 07/12] virtio-gpu: Add virtio_gpu_resource_create_blob

[Kasireddy, Vivek]

Hi Gerd,

> >      res->remapsz = QEMU_ALIGN_UP(res->remapsz,
> > qemu_real_host_page_size);
> >
> >      res->remapped = mmap(NULL, res->remapsz, PROT_READ, @@ -152,7
> > +155,9 @@ void virtio_gpu_init_udmabuf(struct virtio_gpu_simple_resource 
> > *res)
> >          pdata = res->remapped;
> >      }
> >
> > -    (void) pdata;
> > +    if (pdata) {
> > +        res->blob = pdata;
> > +    }
> >  }
> 
> That is confusing.  Patch #2 introduces code which is removed here (probably 
> leftovers
> from udmabuf prototype which didn't use blob resources).  I think it would be 
> useful to
> merge patch #2 with this one.
[Kasireddy, Vivek] Ok, will do.

> 
> Also we might cleanup things a bit.  Do we need separate remapsz + blob_size 
> fields in the
> first place?  Probably not ...
[Kasireddy, Vivek] Right, we don't. I was also going to slightly change the 
names of some
of the new functions in v3 to keep them consistent with the rest of the code. 
Do you have
any additional feedback for the other patches that I can include in v3?

> 
> take care,
>   Gerd
> 
> PS: Can you explicitly cc me on the next version of the patch series?
>     Some patches (this one for example) are on the list only and not in
>     my inbox.  Thanks.
[Kasireddy, Vivek] Sure. I was hoping that including the Based-on-patch-by
tag would do just that but looks like it doesn't. 

Thanks,
Vivek