[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/7] target/ppc: Isolated SPR read/write callbacks
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 3/7] target/ppc: Isolated SPR read/write callbacks |
|
Date: |
Thu, 29 Apr 2021 20:33:53 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 4/29/21 9:21 AM, Bruno Larsen (billionai) wrote:
diff --git a/target/ppc/spr_tcg.c.inc b/target/ppc/spr_tcg.c.inc
new file mode 100644
index 0000000000..48274dd52b
--- /dev/null
+++ b/target/ppc/spr_tcg.c.inc
@@ -0,0 +1,1033 @@
+#include "exec/translator.h"
All new files must have copyright header.
+/* I really see no reason to keep these gen_*_xer */
+/* instead of just leaving the code in the spr_*_xer */
Then just do that, as a separate patch, before or after.
@@ -8515,3 +8471,4 @@ void restore_state_to_opc(CPUPPCState *env,
TranslationBlock *tb,
{
env->nip = data[0];
}
+
Watch the extra whitespace at end of file.
r~
- [PATCH v2 0/7] target/ppc: untangle cpu init from translation, Bruno Larsen (billionai), 2021/04/29
- [PATCH v2 1/7] target/ppc: move opcode table logic to translate.c, Bruno Larsen (billionai), 2021/04/29
- [PATCH v2 2/7] target/ppc: Created !TCG SPR registration macro, Bruno Larsen (billionai), 2021/04/29
- [PATCH v2 3/7] target/ppc: Isolated SPR read/write callbacks, Bruno Larsen (billionai), 2021/04/29
- [PATCH v2 4/7] target/ppc: turned SPR R/W callbacks not static, Bruno Larsen (billionai), 2021/04/29
- [PATCH v2 5/7] target/ppc: removed VSCR from SPR registration, Bruno Larsen (billionai), 2021/04/29
- [PATCH v2 6/7] target/ttc: renamed SPR registration functions, Bruno Larsen (billionai), 2021/04/29