Re: [PATCH 3/4] hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c

[John Snow]

On 4/15/21 6:23 AM, Philippe Mathieu-Daudé wrote:
> Some machines use floppy controllers via the SysBus interface,
> and don't need to pull in all the ISA code.
> Extract the ISA specific code to a new unit: fdc-isa.c, and
> add a new Kconfig symbol: "FDC_ISA".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   hw/block/fdc-isa.c   | 313 +++++++++++++++++++++++++++++++++++++++++++
>   hw/block/fdc.c       | 257 -----------------------------------
>   MAINTAINERS          |   1 +
>   hw/block/Kconfig     |   4 +
>   hw/block/meson.build |   1 +
>   hw/i386/Kconfig      |   2 +-
>   hw/isa/Kconfig       |   6 +-
>   hw/sparc64/Kconfig   |   2 +-
>   8 files changed, 324 insertions(+), 262 deletions(-)
>   create mode 100644 hw/block/fdc-isa.c

LGTM but you'll want someone else to review the Kconfig changes.

Reviewed-by: John Snow <jsnow@redhat.com>