Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string

From:	John Snow
Subject:	Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string
Date:	Mon, 26 Apr 2021 13:43:29 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 4/24/21 4:33 AM, Markus Armbruster wrote:

The second operand of assert provides no additional information.  Please
drop it.


I don't agree with "no additional information", strictly.

I left you a comment on gitlab before you started reviewing on-list.What I wrote there:

"Markus: I know you're not a fan of these, but I wanted a suggestion onhow to explain why this must be true in case it wasn't obvious tosomeone else in the future."


--js

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors, (continued)
- [PATCH 04/22] qapi/parser: factor parsing routine into method, John Snow, 2021/04/21
- [PATCH 08/22] qapi/parser: Use @staticmethod where appropriate, John Snow, 2021/04/21
- [PATCH 06/22] qapi/parser: assert get_expr returns object in outer loop, John Snow, 2021/04/21
  - Re: [PATCH 06/22] qapi/parser: assert get_expr returns object in outer loop, Markus Armbruster, 2021/04/25
- [PATCH 09/22] qapi: add match_nofail helper, John Snow, 2021/04/21
  - Re: [PATCH 09/22] qapi: add match_nofail helper, Markus Armbruster, 2021/04/25
    - Re: [PATCH 09/22] qapi: add match_nofail helper, John Snow, 2021/04/26
- [PATCH 05/22] qapi/parser: Assert lexer value is a string, John Snow, 2021/04/21
  - Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string, Markus Armbruster, 2021/04/24
    - Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string, John Snow <=
    - Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string, Markus Armbruster, 2021/04/27
    - Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string, John Snow, 2021/04/27
- [PATCH 07/22] qapi/parser: assert object keys are strings, John Snow, 2021/04/21
  - Re: [PATCH 07/22] qapi/parser: assert object keys are strings, Markus Armbruster, 2021/04/25
    - Re: [PATCH 07/22] qapi/parser: assert object keys are strings, John Snow, 2021/04/26
    - Re: [PATCH 07/22] qapi/parser: assert object keys are strings, Markus Armbruster, 2021/04/27
    - Re: [PATCH 07/22] qapi/parser: assert object keys are strings, John Snow, 2021/04/27
- [PATCH 12/22] qapi/parser: add type hint annotations, John Snow, 2021/04/21
  - Re: [PATCH 12/22] qapi/parser: add type hint annotations, Markus Armbruster, 2021/04/25
    - Re: [PATCH 12/22] qapi/parser: add type hint annotations, John Snow, 2021/04/26

Prev by Date: Re: [PATCH 03/22] qapi/source: Remove line number from QAPISourceInfo initializer
Next by Date: Re: [PATCH 07/22] qapi/parser: assert object keys are strings
Previous by thread: Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string
Next by thread: Re: [PATCH 05/22] qapi/parser: Assert lexer value is a string
Index(es):
- Date
- Thread