[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 14/25] linux-user/sparc: Fix the stackframe structure
From: |
Richard Henderson |
Subject: |
[PATCH v2 14/25] linux-user/sparc: Fix the stackframe structure |
Date: |
Sun, 25 Apr 2021 19:53:23 -0700 |
Move target_reg_window up and use it. Fold structptr and xxargs
into xargs -- the use of a host pointer was incorrect anyway.
Rename the structure to target_stackf for consistency.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/sparc/signal.c | 38 +++++++++++++++++++++-----------------
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c
index 29c5e3b0c0..3474098641 100644
--- a/linux-user/sparc/signal.c
+++ b/linux-user/sparc/signal.c
@@ -21,16 +21,26 @@
#include "signal-common.h"
#include "linux-user/trace.h"
-/* A Sparc stack frame */
-struct sparc_stackf {
+/* A Sparc register window */
+struct target_reg_window {
abi_ulong locals[8];
abi_ulong ins[8];
- /* It's simpler to treat fp and callers_pc as elements of ins[]
- * since we never need to access them ourselves.
- */
- char *structptr;
- abi_ulong xargs[6];
- abi_ulong xxargs[1];
+};
+
+/* A Sparc stack frame. */
+struct target_stackf {
+ /*
+ * Since qemu does not reference fp or callers_pc directly,
+ * it's simpler to treat fp and callers_pc as elements of ins[],
+ * and then bundle locals[] and ins[] into reg_window.
+ */
+ struct target_reg_window win;
+ /*
+ * Similarly, bundle structptr and xxargs into xargs[].
+ * This portion of the struct is part of the function call abi,
+ * and belongs to the callee for spilling argument registers.
+ */
+ abi_ulong xargs[8];
};
typedef struct {
@@ -56,7 +66,7 @@ typedef struct {
struct target_signal_frame {
- struct sparc_stackf ss;
+ struct target_stackf ss;
__siginfo_t info;
abi_ulong fpu_save;
uint32_t insns[2] QEMU_ALIGNED(8);
@@ -150,10 +160,10 @@ void setup_frame(int sig, struct target_sigaction *ka,
}
for (i = 0; i < 8; i++) {
- __put_user(env->regwptr[i + WREG_L0], &sf->ss.locals[i]);
+ __put_user(env->regwptr[i + WREG_L0], &sf->ss.win.locals[i]);
}
for (i = 0; i < 8; i++) {
- __put_user(env->regwptr[i + WREG_I0], &sf->ss.ins[i]);
+ __put_user(env->regwptr[i + WREG_I0], &sf->ss.win.ins[i]);
}
if (err)
goto sigsegv;
@@ -349,12 +359,6 @@ struct target_ucontext {
target_mcontext_t tuc_mcontext;
};
-/* A V9 register window */
-struct target_reg_window {
- abi_ulong locals[8];
- abi_ulong ins[8];
-};
-
/* {set, get}context() needed for 64-bit SparcLinux userland. */
void sparc64_set_context(CPUSPARCState *env)
{
--
2.25.1
- [PATCH v2 03/25] linux-user: Pass CPUArchState to do_sigaltstack, (continued)
- [PATCH v2 03/25] linux-user: Pass CPUArchState to do_sigaltstack, Richard Henderson, 2021/04/25
- [PATCH v2 07/25] linux-user/sparc: Merge sparc64 target_syscall.h, Richard Henderson, 2021/04/25
- [PATCH v2 04/25] linux-user: Pass CPUArchState to target_restore_altstack, Richard Henderson, 2021/04/25
- [PATCH v2 06/25] linux-user/sparc: Clean up init_thread, Richard Henderson, 2021/04/25
- [PATCH v2 16/25] linux-user/sparc: Split out save_reg_win, Richard Henderson, 2021/04/25
- [PATCH v2 17/25] linux-user/sparc: Clean up get_sigframe, Richard Henderson, 2021/04/25
- [PATCH v2 05/25] linux-user/sparc: Include TARGET_STACK_BIAS in get_sp_from_cpustate, Richard Henderson, 2021/04/25
- [PATCH v2 10/25] linux-user/sparc: Merge sparc64 termbits.h, Richard Henderson, 2021/04/25
- [PATCH v2 22/25] linux-user/sparc: Add 64-bit support to fpu save/restore, Richard Henderson, 2021/04/25
- [PATCH v2 11/25] linux-user/sparc: Merge sparc64/ into sparc/, Richard Henderson, 2021/04/25
- [PATCH v2 14/25] linux-user/sparc: Fix the stackframe structure,
Richard Henderson <=
- [PATCH v2 13/25] linux-user/sparc: Remove target_rt_signal_frame as unused, Richard Henderson, 2021/04/25
- [PATCH v2 15/25] linux-user/sparc: Use target_pt_regs, Richard Henderson, 2021/04/25
- [PATCH v2 20/25] linux-user/sparc: Clean up setup_frame, Richard Henderson, 2021/04/25
- [PATCH v2 24/25] linux-user/sparc: Implement sparc64 rt signals, Richard Henderson, 2021/04/25
- [PATCH v2 09/25] linux-user/sparc: Merge sparc64 target_structs.h, Richard Henderson, 2021/04/25
- [PATCH v2 25/25] tests/tcg/sparc64: Re-enable linux-test, Richard Henderson, 2021/04/25
- [PATCH v2 12/25] linux-user/sparc: Remove target_sigcontext as unused, Richard Henderson, 2021/04/25
- [PATCH v2 08/25] linux-user/sparc: Merge sparc64 target_elf.h, Richard Henderson, 2021/04/25
- [PATCH v2 18/25] linux-user/sparc: Save and restore fpu in signal frame, Richard Henderson, 2021/04/25
- [PATCH v2 19/25] linux-user/sparc: Add rwin_save to signal frame, Richard Henderson, 2021/04/25