qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/8] block: make before-write notifiers thread-safe


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v2 4/8] block: make before-write notifiers thread-safe
Date: Thu, 22 Apr 2021 01:17:11 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1

22.04.2021 00:23, Vladimir Sementsov-Ogievskiy wrote:
19.04.2021 11:55, Emanuele Giuseppe Esposito wrote:
Reads access the list in RCU style, so be careful to avoid use-after-free
scenarios in the backup block job.  Apart from this, all that's needed
is protecting updates with a mutex.

Note that backup doesn't use write-notifiers now. Probably best thing to do is 
to update other users to use filters instead of write notifiers, and drop write 
notifiers at all. But it may require more work, so don't care.

But on the other hand.. Why not. We can go without filter and still drop write-notifiers. 
Look at my new patch "[PATCH] block: simplify write-threshold and drop write 
notifiers"

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]