[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 4/8] qapi/error: assert QAPISourceInfo is not None
From: |
John Snow |
Subject: |
[PATCH v3 4/8] qapi/error: assert QAPISourceInfo is not None |
Date: |
Wed, 21 Apr 2021 15:22:29 -0400 |
Built-in stuff is not parsed from a source file, and therefore have no
QAPISourceInfo. If such None info was used for reporting an error,
built-in stuff would be broken. Programming error. Instead of reporting
a confusing error with bogus source location then, we better crash.
We currently crash only if self.col was set. Assert that self.info is
not None in order to crash reliably.
We can not yet change the type of the initializer to prove this cannot
happen at static analysis time before the remainder of the code is fully
typed.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/error.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/qapi/error.py b/scripts/qapi/error.py
index d179a3bd0c7..d0bc7af6e76 100644
--- a/scripts/qapi/error.py
+++ b/scripts/qapi/error.py
@@ -25,6 +25,7 @@ def __init__(self, info, msg, col=None):
self.col = col
def __str__(self):
+ assert self.info is not None
loc = str(self.info)
if self.col is not None:
assert self.info.line is not None
--
2.30.2
- [PATCH v3 0/8] qapi: static typing conversion, pt4, John Snow, 2021/04/21
- [PATCH v3 1/8] qapi/error: Repurpose QAPIError as an abstract base exception class, John Snow, 2021/04/21
- [PATCH v3 2/8] qapi/error: Use Python3-style super(), John Snow, 2021/04/21
- [PATCH v3 6/8] qapi/error.py: enable pylint checks, John Snow, 2021/04/21
- [PATCH v3 3/8] qapi/error: Make QAPISourceError 'col' parameter optional, John Snow, 2021/04/21
- [PATCH v3 8/8] qapi/error.py: enable mypy checks, John Snow, 2021/04/21
- [PATCH v3 5/8] qapi/error.py: move QAPIParseError to parser.py, John Snow, 2021/04/21
- [PATCH v3 4/8] qapi/error: assert QAPISourceInfo is not None,
John Snow <=
- [PATCH v3 7/8] qapi/error: Add type hints, John Snow, 2021/04/21
- Re: [PATCH v3 0/8] qapi: static typing conversion, pt4, Markus Armbruster, 2021/04/22