Re: [RFC v2 04/13] target/s390x: remove tcg-stub.c

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v2 04/13] target/s390x: remove tcg-stub.c

From:	David Hildenbrand
Subject:	Re: [RFC v2 04/13] target/s390x: remove tcg-stub.c
Date:	Tue, 20 Apr 2021 14:54:21 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 20.04.21 12:36, Claudio Fontana wrote:

now that we protect all calls to the tcg-specific functions
with if (tcg_enabled()), we do not need the TCG stub anymore.

You need compile-time checks, not runtime checks. Any calls have to beprotected by #ifdef, otherwise the compiler might bail out.


Maybe you just wanted to state it differently in this patch description.

--
Thanks,

David / dhildenb

[Prev in Thread]

Current Thread

[Next in Thread]

[RFC v2 00/13] s390x cleanup, Claudio Fontana, 2021/04/20
- [RFC v2 01/13] hw/s390x: only build tod-qemu from the CONFIG_TCG build, Claudio Fontana, 2021/04/20
  - Re: [RFC v2 01/13] hw/s390x: only build tod-qemu from the CONFIG_TCG build, David Hildenbrand, 2021/04/20
- [RFC v2 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c, Claudio Fontana, 2021/04/20
  - Re: [RFC v2 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c, David Hildenbrand, 2021/04/20
- [RFC v2 08/13] target/s390x: make helper.c sysemu-only, Claudio Fontana, 2021/04/20
- [RFC v2 04/13] target/s390x: remove tcg-stub.c, Claudio Fontana, 2021/04/20
  - Re: [RFC v2 04/13] target/s390x: remove tcg-stub.c, David Hildenbrand <=
    - Re: [RFC v2 04/13] target/s390x: remove tcg-stub.c, Claudio Fontana, 2021/04/20
    - Re: [RFC v2 04/13] target/s390x: remove tcg-stub.c, David Hildenbrand, 2021/04/20
    - Re: [RFC v2 04/13] target/s390x: remove tcg-stub.c, Claudio Fontana, 2021/04/20
  - Re: [RFC v2 04/13] target/s390x: remove tcg-stub.c, David Hildenbrand, 2021/04/20
- [RFC v2 03/13] hw/s390x: tod: make explicit checks for accelerators when initializing, Claudio Fontana, 2021/04/20
  - Re: [RFC v2 03/13] hw/s390x: tod: make explicit checks for accelerators when initializing, David Hildenbrand, 2021/04/20
- [RFC v2 05/13] target/s390x: start moving TCG-only code to tcg/, Claudio Fontana, 2021/04/20
  - Re: [RFC v2 05/13] target/s390x: start moving TCG-only code to tcg/, David Hildenbrand, 2021/04/20
    - Re: [RFC v2 05/13] target/s390x: start moving TCG-only code to tcg/, Claudio Fontana, 2021/04/20
- [RFC v2 09/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m, Claudio Fontana, 2021/04/20

Prev by Date: Re: [RFC v2 03/13] hw/s390x: tod: make explicit checks for accelerators when initializing
Next by Date: [PATCH for-6.0?] qga: fix guest-get-disks regression
Previous by thread: [RFC v2 04/13] target/s390x: remove tcg-stub.c
Next by thread: Re: [RFC v2 04/13] target/s390x: remove tcg-stub.c
Index(es):
- Date
- Thread