Re: [PATCH v5 1/9] target/arm: Fix mte_checkN

[Richard Henderson]

On 4/19/21 9:26 AM, Peter Maydell wrote:
> > @@ -779,29 +779,27 @@ uint64_t mte_checkN(CPUARMState *env, uint32_t desc,
> >
> >       mmu_idx = FIELD_EX32(desc, MTEDESC, MIDX);
> >       type = FIELD_EX32(desc, MTEDESC, WRITE) ? MMU_DATA_STORE : MMU_DATA_LOAD;
> > -    esize = FIELD_EX32(desc, MTEDESC, ESIZE);
> >       total = FIELD_EX32(desc, MTEDESC, TSIZE);
> >
> >       /* Find the addr of the end of the access, and of the last element. */
> > -    ptr_end = ptr + total;
> > -    ptr_last = ptr_end - esize;
> > +    ptr_last = ptr + total - 1;
>
> Code change means the comment needs updating, since we're no longer
> finding two things. Change to just
>   /* Find the addr of the end of the access */
>
> ?

Yep, good catch.


r~