[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.0] migration: Drop redundant query-migrate result @bloc
Dr. David Alan Gilbert
Re: [PATCH for-6.0] migration: Drop redundant query-migrate result @blocked
Mon, 19 Apr 2021 18:26:03 +0100
* Peter Maydell (firstname.lastname@example.org) wrote:
> On Mon, 19 Apr 2021 at 17:27, Markus Armbruster <email@example.com> wrote:
> > Result @blocked is true when and only when result @blocked-reasons is
> > present. It's always non-empty when present. @blocked is redundant;
> > drop.
> > Signed-off-by: Markus Armbruster <firstname.lastname@example.org>
So I'm OK with it in principal and I think the code is OK, so
Reviewed-by: Dr. David Alan Gilbert <email@example.com>
> "for-6.0" needs to be accompanied by a justification of why it's
> important to go in the release at this point...
I guess the argument is that when we hit 6.0 it becomes API and removing
the 'blocked' becomes a matter of deprecation which is a pain.
Hmm; I agree it's the right change, but I'm not sure I can justify it
this late in the release.
> -- PMM
Dr. David Alan Gilbert / firstname.lastname@example.org / Manchester, UK