qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 20/26] target/mips: Move TLB management helpers to tcg/sysemu


From: Richard Henderson
Subject: Re: [PATCH 20/26] target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c
Date: Sun, 18 Apr 2021 13:06:13 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/18/21 9:31 AM, Philippe Mathieu-Daudé wrote:
Move TLB management helpers to tcg/sysemu/tlb_helper.c.

Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
4 checkpatch errors:

   ERROR: space prohibited after that '&' (ctx:WxW)
   #414: FILE: target/mips/tcg/sysemu/tlb_helper.c:71:
   +    tlb->XI0 = (env->CP0_EntryLo0 >> CP0EnLo_XI) & 1;
                                                     ^

   ERROR: space prohibited after that '&' (ctx:WxW)
   #415: FILE: target/mips/tcg/sysemu/tlb_helper.c:72:
   +    tlb->RI0 = (env->CP0_EntryLo0 >> CP0EnLo_RI) & 1;
                                                     ^

   ERROR: space prohibited after that '&' (ctx:WxW)
   #420: FILE: target/mips/tcg/sysemu/tlb_helper.c:77:
   +    tlb->XI1 = (env->CP0_EntryLo1 >> CP0EnLo_XI) & 1;
                                                     ^

   ERROR: space prohibited after that '&' (ctx:WxW)
   #421: FILE: target/mips/tcg/sysemu/tlb_helper.c:78:
   +    tlb->RI1 = (env->CP0_EntryLo1 >> CP0EnLo_RI) & 1;
                                                     ^

Wow, that's amazingly bogus. I'm amazed that no one has re-written checkpatch in e.g. sparse...

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]