[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/5] block, migration: improve debugging of migration bdrv_fl

From: Connor Kuehl
Subject: Re: [PATCH 0/5] block, migration: improve debugging of migration bdrv_flush failure
Date: Thu, 15 Apr 2021 14:33:30 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 4/15/21 8:58 AM, Daniel P. Berrangé wrote:
I spent a while debugging a tricky migration failure today which was
ultimately caused by fdatasync() getting EACCESS. The existing probes
were not sufficient to diagnose this, so I had to resort to GDB. This
improves probes and block error reporting to make future diagnosis
possible without GDB.

Daniel P. Berrangé (5):
   migration: add trace point when vm_stop_force_state fails
   softmmu: add trace point when bdrv_flush_all fails
   block: preserve errno from fdatasync failures
   block: add trace point when fdatasync fails
   block: remove duplicate trace.h include

  block/file-posix.c     | 10 +++++-----
  block/trace-events     |  1 +
  migration/migration.c  |  1 +
  migration/trace-events |  1 +
  softmmu/cpus.c         |  7 ++++++-
  softmmu/trace-events   |  3 +++
  6 files changed, 17 insertions(+), 6 deletions(-)

For the series:

Reviewed-by: Connor Kuehl <ckuehl@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]