[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL v2 1/3] osdep: include glib-compat.h before other QEMU headers
From: |
Daniel P . Berrangé |
Subject: |
Re: [PULL v2 1/3] osdep: include glib-compat.h before other QEMU headers |
Date: |
Wed, 14 Apr 2021 18:00:06 +0100 |
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Tue, Apr 13, 2021 at 06:08:48PM +0200, Paolo Bonzini wrote:
> glib-compat.h is sort of like a system header, and it needs to include
> system headers (glib.h) that may dislike being included under
> 'extern "C"'. Move it right after all system headers and before
> all other QEMU headers.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> include/qemu/osdep.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3, Paolo Bonzini, 2021/04/13
- [PULL v2 1/3] osdep: include glib-compat.h before other QEMU headers, Paolo Bonzini, 2021/04/13
- [PULL v2 3/3] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code, Paolo Bonzini, 2021/04/13
- Re: [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3, no-reply, 2021/04/13
- Re: [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3, Peter Maydell, 2021/04/13
- Re: [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3, Peter Maydell, 2021/04/14