On Wed, 14 Apr 2021 15:15:04 +0100
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> wrote:
On 14/04/2021 14:57, Mark Cave-Ayland wrote:
I've definitely seen the same issue as Cornelia in my Gitlab CI builds for the
ESP
security fixes (first version of which appeared just before rc0). The user
builds
always fail on "run-tcg-tests-s390x-linux-user" for me.
Commit 23fff7a17f lies within that range and certainly feels like it could be
relevant to the above failure:
commit 23fff7a17f47420797ac6480147941612152a9ad
Author: Andreas Krebbel <krebbel@linux.ibm.com>
Date: Wed Mar 24 19:51:28 2021 +0100
linux-user/s390x: Use the guest pointer for the sigreturn stub
When setting up the pointer for the sigreturn stub in the return
address register (r14) we currently use the host frame address instead
of the guest frame address.
Note: This only caused problems if Qemu has been built with
--disable-pie (as it is in distros nowadays). Otherwise guest_base
defaults to 0 hiding the actual problem.
Signed-off-by: Andreas Krebbel <krebbel@linux.ibm.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210324185128.63971-1-krebbel@linux.ibm.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
I'll try pushing a test build to Gitlab CI with a revert for that patch on top
and
see if it succeeds for me...
Hm. I'm actually seeing it sometimes succeeding, and sometimes failing.
I'm wondering if there's something else at play here...