Re: [PATCH v4 1/1] docs/devel: Add VFIO device migration documentation

[Cornelia Huck]

On Fri, 9 Apr 2021 19:13:46 +0530
Tarun Gupta <targupta@nvidia.com> wrote:

> Document interfaces used for VFIO device migration. Added flow of state 
> changes
> during live migration with VFIO device.
> 
> Co-developed-by: Kirti Wankhede <kwankhede@nvidia.com>

This still needs Kirti's S-o-b as well (i.e. both tags need to be
paired.)

> Signed-off-by: Tarun Gupta <targupta@nvidia.com>
> ---
> Tested by building docs with new vfio-migration.rst file
> 
> v4:
> - Added info about vfio_listener_log_global_[start|stop]
> - Added info about `save_state` callback.
> - Incorporated comments from v3.
> 
> v3:
> - Add introductory line about VM migration in general.
> - Remove occurcences of vfio_pin_pages() to describe pinning.
> - Incorporated comments from v2
> 
> v2:
> - Included the new vfio-migration.rst file in index.rst
> - Updated dirty page tracking section, also added details about
>   'pre-copy-dirty-page-tracking' opt-out option.
> - Incorporated comments around wording of doc.
> 

The change log and the other extra information also need to be followed
by another '---'.

>  MAINTAINERS                   |   1 +
>  docs/devel/index.rst          |   1 +
>  docs/devel/vfio-migration.rst | 150 ++++++++++++++++++++++++++++++++++
>  3 files changed, 152 insertions(+)
>  create mode 100644 docs/devel/vfio-migration.rst

Aside from the meta issues above, the patch looks good to me.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>