[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] iotests/041: block-job-complete on user-paused job

From: Max Reitz
Subject: Re: [PATCH v2 3/3] iotests/041: block-job-complete on user-paused job
Date: Fri, 9 Apr 2021 15:45:11 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0

On 09.04.21 15:29, Max Reitz wrote:
Expand test_pause() to check what happens when issuing
block-job-complete on a job that is on STANDBY because it has been
paused by the user.  (This should be an error, and in particular not
hang job_wait_unpaused().)

Signed-off-by: Max Reitz <mreitz@redhat.com>
  tests/qemu-iotests/041 | 13 ++++++++++++-
  1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index 5cc02b24fc..d2c9669741 100755
--- a/tests/qemu-iotests/041
+++ b/tests/qemu-iotests/041
@@ -120,7 +120,18 @@ class TestSingleDrive(iotests.QMPTestCase):
          result = self.vm.qmp('block-job-resume', device='drive0')
          self.assert_qmp(result, 'return', {})
- self.complete_and_wait()
+        self.wait_ready()
+        # Check that a job on STANDBY cannot be completed
+        self.pause_job('drive0')
+        result = self.vm.qmp('block-job-complete', device='drive0')
+        self.assert_qmp(result, 'error/desc',
+                        "Job 'drive0' has been paused by the user")

Oops.  Should now be

"Job 'drive0' has been paused and needs to be explicitly resumed"

of course.


+        result = self.vm.qmp('block-job-resume', device='drive0')
+        self.assert_qmp(result, 'return', {})
+        self.complete_and_wait(wait_ready=False)
          self.assertTrue(iotests.compare_images(test_img, target_img),
                          'target image does not match source after mirroring')

reply via email to

[Prev in Thread] Current Thread [Next in Thread]