Re: [PATCH 1/2] hw/block/nvme: store aiocb in compare

[Gollu Appalanaidu]

On Thu, Apr 08, 2021 at 09:37:08PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> nvme_compare() fails to store the aiocb from the blk_aio_preadv() call.
> Fix this.
>
> Fixes: 0a384f923f51 ("hw/block/nvme: add compare command")
> Cc: Gollu Appalanaidu <anaidu.gollu@samsung.com>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/block/nvme.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 6b1f056a0ebc..94bc373260be 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -2837,7 +2837,8 @@ static uint16_t nvme_compare(NvmeCtrl *n, NvmeRequest 
> *req)
>
>     block_acct_start(blk_get_stats(blk), &req->acct, data_len,
>                      BLOCK_ACCT_READ);
> -    blk_aio_preadv(blk, offset, &ctx->data.iov, 0, nvme_compare_data_cb, req);
> +    req->aiocb = blk_aio_preadv(blk, offset, &ctx->data.iov, 0,
> +                                nvme_compare_data_cb, req);
>
>     return NVME_NO_COMPLETE;
> }
> --

Reviewed-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>

> 2.31.1