Re: [PATCH v2 10/10] nbd: move connection code from block/nbd to nbd/client-connection

[Vladimir Sementsov-Ogievskiy]

08.04.2021 20:04, Roman Kagan wrote:
> On Thu, Apr 08, 2021 at 05:08:27PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > We now have bs-independent connection API, which consists of four
> > functions:
> >
> >    nbd_client_connection_new()
> >    nbd_client_connection_unref()
> >    nbd_co_establish_connection()
> >    nbd_co_establish_connection_cancel()
> >
> > Move them to a separate file together with NBDClientConnection
> > structure which becomes private to the new API.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> >
> > Hmm. I keep only Virtuozzo's copyright in a new file, as actually I've
> > developed nbd-reconnection code. Still probably safer to save all
> > copyrights. Let me now if you think so and I'll add them.
>
> Not my call.
>
> >   include/block/nbd.h     |  11 +++
> >   block/nbd.c             | 167 ----------------------------------
> >   nbd/client-connection.c | 192 ++++++++++++++++++++++++++++++++++++++++
> >   nbd/meson.build         |   1 +
> >   4 files changed, 204 insertions(+), 167 deletions(-)
> >   create mode 100644 nbd/client-connection.c
>
> Reviewed-by: Roman Kagan <rvkagan@yandex-team.ru>

Thanks a lot for reviewing!

--
Best regards,
Vladimir