[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.0? 1/3] job: Add job_wait_unpaused() for block-job-comp
Re: [PATCH for-6.0? 1/3] job: Add job_wait_unpaused() for block-job-complete
Thu, 8 Apr 2021 13:04:12 -0400
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1
On 4/8/21 12:58 PM, Vladimir Sementsov-Ogievskiy wrote:
job-complete command is async. Can we instead just add a boolean like
job->completion_requested, and set it if job-complete called in STANDBY
state, and on job_resume job_complete will be called automatically if
this boolean is true?
job_complete has a synchronous setup, though -- we lose out on a lot of
synchronous error checking in that circumstance.
I was not able to audit it to determine that it'd be safe to attempt
that setup during a drained section -- I imagine it won't work and will
So I thought we'd have to signal completion and run the setup *later*,
but what do we do if we get an error then? Does the entire job fail? Do
we emit some new event? ("BLOCK_JOB_COMPLETION_FAILED" ?) Is it recoverable?
So on and so forth. Seems like a lot of things to consider, unless I am
making a giant fuss about nothing again, not like that's ever happened. O:-)
Re: [PATCH for-6.0? 1/3] job: Add job_wait_unpaused() for block-job-complete, Vladimir Sementsov-Ogievskiy, 2021/04/08
Re: [PATCH for-6.0? 1/3] job: Add job_wait_unpaused() for block-job-complete, Max Reitz, 2021/04/09
Re: [PATCH for-6.0? 0/3] job: Add job_wait_unpaused() for block-job-complete, John Snow, 2021/04/08
- [PATCH for-6.0? 3/3] iotests/041: block-job-complete on user-paused job, (continued)