[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 04/11] qemu-iotests: delay QMP socket timers

From: Emanuele Giuseppe Esposito
Subject: Re: [RFC PATCH v2 04/11] qemu-iotests: delay QMP socket timers
Date: Thu, 8 Apr 2021 18:06:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 08/04/2021 17:40, Paolo Bonzini wrote:
On 07/04/21 15:50, Emanuele Giuseppe Esposito wrote:
      def get_qmp_events_filtered(self, wait=60.0):
          result = []
-        for ev in self.get_qmp_events(wait=wait):
+        qmp_wait = wait
+        if qemu_gdb:
+            qmp_wait = 0.0
+        for ev in self.get_qmp_events(wait=qmp_wait):
          return result

Should this be handled in get_qmp_events instead, since you're basically changing all the callers?

get_qmp_events is in python/machine.py, which as I understand might be used also by some other scripts, so I want to keep the changes there to the minimum. Also, machine.py has no access to qemu_gdb or qemu_valgrind, so passing a boolean or something to delay the timer would still require to add a similar check in all sections.

Or do you have a cleaner way to do this?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]