[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/1] decodetree: Add support for 64-bit instructions

From: Richard Henderson
Subject: Re: [PATCH 1/1] decodetree: Add support for 64-bit instructions
Date: Wed, 7 Apr 2021 08:18:09 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/7/21 7:59 AM, Luis Fernando Fujita Pires wrote:
Allow '64' to be specified for the instruction width command line params
and use the appropriate insn/field data types, mask, extract and deposit
functions in that case.

This will be used to implement the new 64-bit Power ISA 3.1 instructions.

Signed-off-by: Luis Pires <luis.pires@eldorado.org.br>
  docs/devel/decodetree.rst |  3 ---
  scripts/decodetree.py     | 25 ++++++++++++++++++++-----
  2 files changed, 20 insertions(+), 8 deletions(-)

Looks good.

--- a/docs/devel/decodetree.rst
+++ b/docs/devel/decodetree.rst
@@ -40,9 +40,6 @@ and returns an integral value extracted from there.

  A field with no ``unnamed_fields`` and no ``!function`` is in error.

-FIXME: the fields of the structure into which this result will be stored
-is restricted to ``int``.  Which means that we cannot expand 64-bit items.

Let's replace this FIXME with a sentence or two documenting the type used.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]