[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/14] block/nbd: nbd_co_establish_connection(): drop unused

From: Roman Kagan
Subject: Re: [PATCH 02/14] block/nbd: nbd_co_establish_connection(): drop unused errp
Date: Wed, 7 Apr 2021 14:28:49 +0300

On Wed, Apr 07, 2021 at 01:46:25PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> We are going to refactor connection logic to make it more
> understandable. Every bit that we can simplify in advance will help.
> Drop errp for now, it's unused anyway. We'll probably reimplement it in
> future.

Although I agree that this passing errors around is a bit of an
overkill, my problem with NBD client is that it's notoriously silent
about problems it expeirences, and those errors never pop up in logs.

Given that these errors are not guest-triggerable, and probably indicate
serious problems at the infrastructure level, instead of endlessly
passing them around (as in the code ATM) or dropping them on the floor
(as you propose in the patch) I'd much rather log them immediately when

I have a patch to that end, I'll try to port it on top of your series.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]