[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 14/21] Hexagon (target/hexagon) add A5_ACS (vacsh)
|
From: |
Taylor Simpson |
|
Subject: |
RE: [PATCH v2 14/21] Hexagon (target/hexagon) add A5_ACS (vacsh) |
|
Date: |
Tue, 6 Apr 2021 21:31:19 +0000 |
> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Tuesday, April 6, 2021 3:51 PM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: philmd@redhat.com; ale@rev.ng; Brian Cain <bcain@quicinc.com>
> Subject: Re: [PATCH v2 14/21] Hexagon (target/hexagon) add A5_ACS
> (vacsh)
>
> On 3/31/21 8:53 PM, Taylor Simpson wrote:
> > +#define fGEN_TCG_A5_ACS(SHORTCODE) \
> > + do { \
> > + gen_helper_vacsh_val(RxxV, cpu_env, RxxV, RssV, RttV); \
> > + gen_helper_vacsh_pred(PeV, cpu_env, RxxV, RssV, RttV); \
> > + } while (0)
>
> You've modified RxxV before its last use.
> I think just swapping the two lines is sufficient.
Good catch! I'll have to write a test that exposes this.