Re: [PATCH] tests/acceptance: Add a 'virt_kvm' test using the GICv3

[Philippe Mathieu-Daudé]

On 3/31/21 5:45 PM, Alex Bennée wrote:
> 
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> 
>> The current 'virt_kvm' test is restricted to GICv2, but can also
>> work with a GICv3. Duplicate it but add a GICv3 test which can be
>> tested on some hardware.
>>
>> Noticed while running:
>>
>>  $ avocado --show=app run -t machine:virt tests/acceptance/
>>  ...
>>  (2/6) tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm: ERROR: 
>> Unexpected empty reply from server (1.82 s)
>>
>> The job.log content is:
>>
>>   L0351 DEBUG| Output: 'qemu-system-aarch64: host does not support in-kernel 
>> GICv2 emulation\n'
>>
>> With this patch:
>>
>>  $ avocado --show=app run -t device:gicv3 tests/acceptance/
>>  (1/1)
>>  tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm_gicv3:
>>  PASS (55.10 s)
> 
> On the new aarch64 machine which is GICv3 I get the following:
> 
>  (006/142) 
> tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm_gicv2: ERROR: 
> Unexpected empty reply from server (0.47 s)
> 
> which it shouldn't have run. However:
> 
>   ./tests/venv/bin/avocado --show=app run -t device:gic3 tests/acceptance/
>   Test Suite could not be create. No test references provided nor any other 
> arguments resolved into tests
> 
> Is this something that has regressed or am I doing it wrong?

Typo in the tag: "device:gic3" -> "device:gicv3"

>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  tests/acceptance/boot_linux.py | 17 ++++++++++++++++-
>>  1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py
>> index 0055dc7cee..c743e231f4 100644
>> --- a/tests/acceptance/boot_linux.py
>> +++ b/tests/acceptance/boot_linux.py
>> @@ -182,10 +182,11 @@ def test_virt_tcg(self):
>>          self.add_common_args()
>>          self.launch_and_wait()
>>  
>> -    def test_virt_kvm(self):
>> +    def test_virt_kvm_gicv2(self):
>>          """
>>          :avocado: tags=accel:kvm
>>          :avocado: tags=cpu:host
>> +        :avocado: tags=device:gicv2
>>          """
>>          if not kvm_available(self.arch, self.qemu_bin):
>>              self.cancel(KVM_NOT_AVAILABLE)
>> @@ -195,6 +196,20 @@ def test_virt_kvm(self):
>>          self.add_common_args()
>>          self.launch_and_wait()
>>  
>> +    def test_virt_kvm_gicv3(self):
>> +        """
>> +        :avocado: tags=accel:kvm
>> +        :avocado: tags=cpu:host
>> +        :avocado: tags=device:gicv3
>> +        """
>> +        if not kvm_available(self.arch, self.qemu_bin):
>> +            self.cancel(KVM_NOT_AVAILABLE)
>> +        self.vm.add_args("-accel", "kvm")
>> +        self.vm.add_args("-cpu", "host")
>> +        self.vm.add_args("-machine", "virt,gic-version=3")
>> +        self.add_common_args()
>> +        self.launch_and_wait()
>> +
>>  
>>  class BootLinuxPPC64(BootLinux):
>>      """
> 
>