[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 2/4] Add NVMM accelerator: x86 CPU support
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v7 2/4] Add NVMM accelerator: x86 CPU support |
|
Date: |
Fri, 2 Apr 2021 14:51:41 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 4/2/21 1:25 PM, Reinoud Zandijk wrote:
+i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true:
+ declare_dependency(link_args: ['-lnvmm'])
+)
You shouldn't be playing with link flags directly.
In patch 1, you found the nvmm library, and assigned it to the variable 'nvmm'.
You should just add the library as a dependency and let meson figure out what
to do.
So I think this should just be
i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true: nvmm)
r~