qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 07/11] tests/tcg: relax the next step precision of the gdb


From: Richard Henderson
Subject: Re: [PATCH v2 07/11] tests/tcg: relax the next step precision of the gdb sha1 test
Date: Fri, 2 Apr 2021 11:38:25 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/2/21 9:41 AM, Richard Henderson wrote:
On 4/1/21 3:25 AM, Alex Bennée wrote:
      check_break("SHA1Init")
-    # check step and inspect values
+    # Check step and inspect values. We do a double next after the
+    # breakpoint as depending on the version of gdb we may step the
+    # preamble and not the first actual line of source.
+    gdb.execute("next")
      gdb.execute("next")
      val_ctx = gdb.parse_and_eval("context->state[0]")
      exp_ctx = 0x67452301

This double next seems just as fragile.  Why don't you just set the breakpoint where you want, which appears to be sha1.c:138?

That said, make check-tcg has passed, completely, on my laptop for the first time in a year. So,

Tested-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]