[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended

From: Vincent Bernat
Subject: Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information)
Date: Thu, 01 Apr 2021 23:07:06 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

 ❦  1 avril 2021 22:58 +02, Igor Mammedov:

>> This can be invoked with:
>>     $QEMU -netdev user,id=internet
>>           -device 
>> virtio-net-pci,mac=50:54:00:00:00:42,netdev=internet,id=internet-dev \
>>           -smbios type=41,designation='Onboard 
>> LAN',instance=1,kind=ethernet,pcidev=internet-dev
> an ACPI alternative was merged recently (current master).
> assigning 'designation=' wasn't implemented there, but important part
> of giving users control over PCI devices 'eno' index is implemented.
> When I looked into the issue, smbios way was a bit over-kill for the task
> and didn't really work if hotplug were used.
> See, for example how to use new feature:
>  https://www.mail-archive.com/qemu-devel@nongnu.org/msg794164.html

It seems simpler this way. I don't think my patch is needed then.
Let the data structure the program.
            - The Elements of Programming Style (Kernighan & Plauger)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]