[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 10/10] Fixed calculation error of pkt->header_size in fill_pkt
From: |
leirao |
Subject: |
[PATCH v5 10/10] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info() |
Date: |
Thu, 1 Apr 2021 15:47:29 +0800 |
From: "Rao, Lei" <lei.rao@intel.com>
The data pointer has skipped vnet_hdr_len in the function of
parse_packet_early().So, we can not subtract vnet_hdr_len again
when calculating pkt->header_size in fill_pkt_tcp_info(). Otherwise,
it will cause network packet comparsion errors and greatly increase
the frequency of checkpoints.
Signed-off-by: Lei Rao <lei.rao@intel.com>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
---
net/colo-compare.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 5b538f4..b100e7b 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -211,7 +211,7 @@ static void fill_pkt_tcp_info(void *data, uint32_t *max_ack)
pkt->tcp_ack = ntohl(tcphd->th_ack);
*max_ack = *max_ack > pkt->tcp_ack ? *max_ack : pkt->tcp_ack;
pkt->header_size = pkt->transport_header - (uint8_t *)pkt->data
- + (tcphd->th_off << 2) - pkt->vnet_hdr_len;
+ + (tcphd->th_off << 2);
pkt->payload_size = pkt->size - pkt->header_size;
pkt->seq_end = pkt->tcp_seq + pkt->payload_size;
pkt->flags = tcphd->th_flags;
--
1.8.3.1
- RE: [PATCH v5 03/10] Optimize the function of filter_send, (continued)
- [PATCH v5 04/10] Remove migrate_set_block_enabled in checkpoint, leirao, 2021/04/01
- [PATCH v5 05/10] Add a function named packet_new_nocopy for COLO., leirao, 2021/04/01
- [PATCH v5 06/10] Add the function of colo_compare_cleanup, leirao, 2021/04/01
- [PATCH v5 07/10] Reset the auto-converge counter at every checkpoint., leirao, 2021/04/01
- [PATCH v5 08/10] Reduce the PVM stop time during Checkpoint, leirao, 2021/04/01
- [PATCH v5 09/10] Add the function of colo_bitmap_clear_dirty, leirao, 2021/04/01
- [PATCH v5 10/10] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info(),
leirao <=
- Re: [PATCH v5 00/10] Fixed some bugs and optimized some codes for COLO, Lukas Straub, 2021/04/04