[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug: object-add qmp command that used to work fails now
From: |
Eric Blake |
Subject: |
Re: Bug: object-add qmp command that used to work fails now |
Date: |
Wed, 31 Mar 2021 15:16:18 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 3/31/21 3:00 PM, Lukas Straub wrote:
> Hi,
> This qmp command that used to work:
> {"execute": "object-add", "arguments": {"qom-type": "filter-mirror", "id":
> "m0", "props": {"netdev": "hn0", "queue": "tx", "outdev": "mirror0",
> "vnet_hdr_support": false}}}
> now fails with the following error:
> {"error": {"class": "GenericError", "desc": "Parameter 'netdev' is missing"}}
>
> I haven't looked closely into it, but I think
> 9151e59a8b6e854eb733553c6772351049ca6ab6 "qapi/qom: QAPIfy object-add"
> is the culprint.
Try getting rid of the nesting caused by props:
{"execute": "object-add", "arguments": {"qom-type": "filter-mirror",
"id": "m0", "netdev": "hn0", "queue": "tx", "outdev": "mirror0",
"vnet_hdr_support": false}}
Per docs/system/removed-features.rst, the change was intentional:
> ``object-add`` option ``props`` (removed in 6.0)
> ''''''''''''''''''''''''''''''''''''''''''''''''
>
> Specify the properties for the object as top-level arguments instead.
although it is unfortunate that you didn't notice the change during the
deprecation cycle.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org