Re: [PATCH 16/24] DAX/unmap: virtiofsd: Add VHOST_USER_SLAVE_FS_IO

[Stefan Hajnoczi]

On Tue, Mar 16, 2021 at 07:59:59PM +0000, Dr. David Alan Gilbert wrote:
> * Stefan Hajnoczi (stefanha@redhat.com) wrote:
> > On Tue, Feb 09, 2021 at 07:02:16PM +0000, Dr. David Alan Gilbert (git) 
> > wrote:
> > > +            if (!mrs_size) {
> > > +                error_report("No guest region found for 0x%" 
> > > HWADDR_PRIx, gpa);
> > > +                res = -EFAULT;
> > > +                break;
> > > +            }
> > > +
> > > +            trace_vhost_user_fs_slave_io_loop(mrs.mr->name,
> > > +                                          
> > > (uint64_t)mrs.offset_within_region,
> > > +                                          memory_region_is_ram(mrs.mr),
> > > +                                          memory_region_is_romd(mrs.mr),
> > > +                                          (size_t)mrs_size);
> > > +
> > > +            void *hostptr = qemu_map_ram_ptr(mrs.mr->ram_block,
> > > +                                             mrs.offset_within_region);
> > > +            ssize_t transferred;
> > > +            if (sm->flags[i] & VHOST_USER_FS_FLAG_MAP_R) {
> > 
> > The flag name is specific to map requests but it's shared with the IO
> > request. Perhaps rename the flags?
> 
> They're both read/write's; do you have a preferred alternative?

VHOST_USER_FS_FLAG_<what it does> (read? readwrite? etc)

Stefan

signature.asc
Description: PGP signature