[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/5] hw/ppc: e500: Add missing #address-cells and #size-cells in t
From: |
David Gibson |
Subject: |
[PULL 1/5] hw/ppc: e500: Add missing #address-cells and #size-cells in the eTSEC node |
Date: |
Wed, 31 Mar 2021 17:25:20 +1100 |
From: Bin Meng <bin.meng@windriver.com>
Per devicetree spec v0.3 [1] chapter 2.3.5:
The #address-cells and #size-cells properties are not inherited
from ancestors in the devicetree. They shall be explicitly defined.
If missing, a client program should assume a default value of 2
for #address-cells, and a value of 1 for #size-cells.
These properties are currently missing, causing the <reg> property
of the queue-group subnode to be incorrectly parsed using default
values.
[1]
https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf
Fixes: fdfb7f2cdb2d ("e500: Add support for eTSEC in device tree")
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Message-Id: <20210311081608.66891-1-bmeng.cn@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/e500.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index 1d94485ac8..79467ac512 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -237,6 +237,8 @@ static int create_devtree_etsec(SysBusDevice *sbdev,
PlatformDevtreeData *data)
qemu_fdt_setprop_string(fdt, node, "model", "eTSEC");
qemu_fdt_setprop(fdt, node, "local-mac-address", etsec->conf.macaddr.a, 6);
qemu_fdt_setprop_cells(fdt, node, "fixed-link", 0, 1, 1000, 0, 0);
+ qemu_fdt_setprop_cells(fdt, node, "#size-cells", 1);
+ qemu_fdt_setprop_cells(fdt, node, "#address-cells", 1);
qemu_fdt_add_subnode(fdt, group);
qemu_fdt_setprop_cells(fdt, group, "reg", mmio0, 0x1000);
--
2.30.2
- [PULL 0/5] ppc-for-6.0 queue 20210331, David Gibson, 2021/03/31
- [PULL 2/5] target/ppc/kvm: Cache timebase frequency, David Gibson, 2021/03/31
- [PULL 1/5] hw/ppc: e500: Add missing #address-cells and #size-cells in the eTSEC node,
David Gibson <=
- [PULL 3/5] spapr: Assert DIMM unplug state in spapr_memory_unplug(), David Gibson, 2021/03/31
- [PULL 4/5] spapr: Fix typo in the patb_entry comment, David Gibson, 2021/03/31
- [PULL 5/5] hw/net: fsl_etsec: Tx padding length should exclude CRC, David Gibson, 2021/03/31
- Re: [PULL 0/5] ppc-for-6.0 queue 20210331, Peter Maydell, 2021/03/31