[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 4/8] qapi/error: Change assertion
From: |
John Snow |
Subject: |
[PATCH v2 4/8] qapi/error: Change assertion |
Date: |
Tue, 30 Mar 2021 13:18:40 -0400 |
Eventually, we'll be able to prove that 'info.line' must be an int and
is never None at static analysis time, and this assert can go
away. Until then, it's a type error to assume that self.info is not
None.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/error.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/qapi/error.py b/scripts/qapi/error.py
index d179a3bd0c..d0bc7af6e7 100644
--- a/scripts/qapi/error.py
+++ b/scripts/qapi/error.py
@@ -25,6 +25,7 @@ def __init__(self, info, msg, col=None):
self.col = col
def __str__(self):
+ assert self.info is not None
loc = str(self.info)
if self.col is not None:
assert self.info.line is not None
--
2.30.2
- [PATCH v2 0/8] qapi: static typing conversion, pt4, John Snow, 2021/03/30
- [PATCH v2 4/8] qapi/error: Change assertion,
John Snow <=
- [PATCH v2 2/8] qapi/error: Use Python3-style super(), John Snow, 2021/03/30
- [PATCH v2 7/8] qapi/error: Add type hints, John Snow, 2021/03/30
- [PATCH v2 1/8] qapi/error: Repurpose QAPIError as a generic exception base class, John Snow, 2021/03/30
- [PATCH v2 6/8] qapi/error.py: enable pylint checks, John Snow, 2021/03/30
- [PATCH v2 3/8] qapi/error: Make QAPISourceError 'col' parameter optional, John Snow, 2021/03/30
- [PATCH v2 8/8] qapi/error.py: enable mypy checks, John Snow, 2021/03/30
- [PATCH v2 5/8] qapi/error.py: move QAPIParseError to parser.py, John Snow, 2021/03/30