Re: [PATCH 2/4] migrate-bitmaps-postcopy-test: Fix pylint warnings

[Vladimir Sementsov-Ogievskiy]

29.03.2021 16:26, Max Reitz wrote:
> pylint complains that discards1_sha256 and all_discards_sha256 are first
> set in non-__init__ methods.  Let's make it happy.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>   tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test 
> b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> index 584062b412..013e94fc39 100755
> --- a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> +++ b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> @@ -76,6 +76,9 @@ def check_bitmaps(vm, count):
>   
>   
>   class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
> +    discards1_sha256 = None
> +    all_discards_sha256 = None
> +
>       def tearDown(self):
>           if debug:
>               self.vm_a_events += self.vm_a.get_qmp_events()

I'd prefer not making them class-variables. I think initializing them in setUp 
should work (as a lot of other variables are initialized in setUp() and pylint 
doesn't complain). And better thing is return it together with event_resume 
from start_postcopy(), as actually it's a kind of result of the function.

--
Best regards,
Vladimir